Thank you for your report. We will add this fix in our roadmap. 

Thanks,
Costas

On Oct 14, 2018, at 5:14 AM, David Binderman <dcb314@hotmail.com> wrote:

Hello there,

snort-2.9.12/src/dynamic-preprocessors/appid/appId_ss.c:205]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

        if ((rval = ConsumeAppIdSSMsg(msg_header->type, msg + offset, msg_header->data_length) != 0))

Maybe better code

        if ((rval = ConsumeAppIdSSMsg(msg_header->type, msg + offset, msg_header->data_length)) != 0)

Regards

David Binderman