<div dir="ltr"><div><div><div>Hi.  That code looks correct w/o patching.  strncasecmp(a,b) returns zero if a matches b.<br><br></div>I'm not clear on the issue that you are having.  What is your ftp configuration and what are you trying to do?<br>
<br></div><div>Let me know and we'll try to get it figured out.<br></div><div><br></div>Thanks<br></div>Russ<br><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 12, 2013 at 3:30 AM, Reinoud Koornstra <span dir="ltr"><<a href="mailto:sockstat@...445..." target="_blank">sockstat@...445...</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">


<div><div dir="ltr">Hi Everyone,<br>
 <br>
I've been struggeling with trying to get trying to active this option Identify open data channels.<br>
Even with the parameter ignore_data_chan no, it wouldn't activate.<br>
After some instrumentation I found that we were turning it off because of a comparison that didn't go right.<br>
Even with ignore_data_chan set to no, we'd still come in the else if which wasn't correct.<br>
Here's a fix to the problem:<br>
 <br>
---- src/dynamic-preprocessors/ftptelnet/snort_ftptelnet.c.orig 2013-09-12 00:17:29.301433818 -0700<br>+++ src/dynamic-preprocessors/ftptelnet/snort_ftptelnet.c 2013-09-12 00:21:54.441437865 -0700<br>@@ -1403,11 +1403,11 @@<br>
                                          confOption);<br>         return FTPP_FATAL_ERR;<br>     }<br>-    if (!strcasecmp("yes", pcToken))<br>+    if (strncmp("yes", pcToken, 3) != 0)<br>     {<br>         ServerConf->data_chan = 1;<br>
     }<br>-    else if (!strcasecmp("no", pcToken))<br>+    else if (strncmp("no", pcToken, 2) != 0)<br>     {<br>         if (ServerConf->data_chan == 1)<br>         {<br>
 <br>
Thanks,<span class="HOEnZb"><font color="#888888"><br>
 <br>
Reinoud.<br>                                        </font></span></div></div>
<br>------------------------------------------------------------------------------<br>
How ServiceNow helps IT people transform IT departments:<br>
1. Consolidate legacy IT systems to a single system of record for IT<br>
2. Standardize and globalize service processes across IT<br>
3. Implement zero-touch automation to replace manual, redundant tasks<br>
<a href="http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk" target="_blank">http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk</a><br>_______________________________________________<br>

Snort-devel mailing list<br>
<a href="mailto:Snort-devel@lists.sourceforge.net">Snort-devel@...1685...ceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/snort-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/snort-devel</a><br>
Archive:<br>
<a href="http://sourceforge.net/mailarchive/forum.php?forum_name=snort-devel" target="_blank">http://sourceforge.net/mailarchive/forum.php?forum_name=snort-devel</a><br>
<br>
Please visit <a href="http://blog.snort.org" target="_blank">http://blog.snort.org</a> for the latest news about Snort!<br></blockquote></div><br></div>