[Snort-devel] [PATCH]: Fix IP Protocol variable data type in Stream5 Preprocessor

Carter Waxman (cwaxman) cwaxman at ...3461...
Mon Mar 10 11:28:35 EDT 2014


Hello Joshua,

Apologies for the delayed response, we have bugged this internally.

Thanks for spotting this,
Carter



On 2/18/14 1:26 AM, "Joshua Kinard" <kumba at ...2185...> wrote:

>
>Hello snort-devel,
>
>I found a few more spots in Stream5 where a 'char' is used to hold the IP
>Protocol number, which is wrong.  IP proto runs from 0-255, which a char
>won't handle, being that it's a signed 8-bit integer.  The attached patch
>changes this to a uint8_t data type in the affected spots, as well as a
>few
>instances of a signed 32-bit integer in the
>s5SetPortFilterStatus/s5UnsetPortFilterStatus function definitions.
>
>
> Stream5/snort_stream5_session.c |    4 ++--
> Stream5/snort_stream5_session.h |    2 +-
> Stream5/stream5_ha.c            |    2 +-
> spp_stream5.c                   |   16 ++++++++--------
> stream_api.h                    |    8 ++++----
> 5 files changed, 16 insertions(+), 16 deletions(-)
>
>
>Cheers!,
>
>-- 
>Joshua Kinard
>Gentoo/MIPS
>kumba at ...2185...
>4096R/D25D95E3 2011-03-28
>
>"The past tempts us, the present confuses us, the future frightens us.
>And
>our lives slip away, moment by moment, lost in that vast, terrible
>in-between."
>
>--Emperor Turhan, Centauri Republic





More information about the Snort-devel mailing list