[Snort-devel] Compliance to C (ISO 9899)?

Andreas Borchert borchert at ...1577...
Wed Sep 18 06:17:07 EDT 2002


Dear developers of snort,

I wonder if there is any interest to get the sources of snort in
compliance to the standard for C (ISO 9899). Current practice in the
sources of snort is the unconditional inclusion of a large set of specific
gcc features. Examples are the use of __inline__ and expressions with
embedded blocks:

    #define EXTRACT_32BITS(p)  ({ u_int32_t __tmp; memmove(&__tmp, (p), sizeof(u
    _int32_t)); (u_int32_t) ntohl(__tmp);})
    [line 384 in config.h of snort-1.8.7]

    fprintf(fp, "Echo: %u ", EXTRACT_32BITS(tmp));
    [line 2309 in log.c of snort-1.8.7]

These problems were already noted before and patches were also offered [1]
but apparently ignored or rejected.

Andreas.

[1] http://www.geocrawler.com/archives/3/5344/2001/8/50/6436916/

-- 
Andreas Borchert, Universitaet Ulm, SAI, Helmholtzstr. 18, 89069 Ulm,  Germany
E-Mail: borchert at ...1577...
WWW:	http://www.mathematik.uni-ulm.de/sai/borchert/
PGP:    http://www.mathematik.uni-ulm.de/sai/borchert/pgp.html




More information about the Snort-devel mailing list